Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add legend_labels option to allow overriding legend labels #5342

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Add legend_labels option to allow overriding legend labels #5342

merged 5 commits into from
Jun 24, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 21, 2022 •
edited by jbednar
Loading

Fixes #5322

jbednar
jbednar approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me; not sure why 30 tests are failing!

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2022 •
edited
Loading

Codecov Report

Merging #5342 (c230494) into master (3d3154a) will increase coverage by 0.04%.
The diff coverage is 98.78%.

@@            Coverage Diff             @@
##           master    #5342      +/-   ##
==========================================
+ Coverage   88.11%   88.16%   +0.04%     
==========================================
  Files         300      300              
  Lines       61874    61912      +38     
==========================================
+ Hits        54522    54585      +63     
+ Misses       7352     7327      -25
Impacted Files Coverage Δ
holoviews/operation/datashader.py 83.98% <ø> (+1.78%) ⬆️
holoviews/plotting/util.py 69.49% <ø> (ø)
holoviews/plotting/bokeh/element.py 88.86% <95.65%> (+0.06%) ⬆️
holoviews/plotting/bokeh/raster.py 71.30% <100.00%> (ø)
holoviews/plotting/mpl/element.py 90.02% <100.00%> (+0.06%) ⬆️
holoviews/plotting/mpl/raster.py 77.77% <100.00%> (+0.07%) ⬆️
holoviews/tests/plotting/bokeh/test_overlayplot.py 100.00% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_pathplot.py 100.00% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_pointplot.py 100.00% <100.00%> (ø)
...iews/tests/plotting/matplotlib/test_overlayplot.py 97.70% <100.00%> (+0.40%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3154a...c230494. Read the comment docs.

@philippjfr philippjfr merged commit d4a2de2 into master Jun 24, 2022
@philippjfr philippjfr deleted the legend_labels branch June 24, 2022 22:27
@korsbakken korsbakken mentioned this pull request Jan 30, 2023
Closed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbednar jbednar jbednar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support legend label mapping
3 participants
@philippjfr @codecov-commenter @jbednar